Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add surface shape performance test #701

Open
wants to merge 25 commits into
base: develop
Choose a base branch
from
Open

Add surface shape performance test #701

wants to merge 25 commits into from

Conversation

zglueck
Copy link
Contributor

@zglueck zglueck commented May 21, 2018

Description of the Change

This PR adds a functional test which measures SurfaceShape performance. Both static and moving surface shapes are tested using an automated navigation technique.

Applicable Issues

Closes #694

zglueck added 18 commits May 16, 2018 23:10
@zglueck zglueck self-assigned this May 21, 2018
@zglueck zglueck requested review from markpet49 and pdavidc May 21, 2018 22:01
@ghost ghost added the needs review label May 21, 2018
@pdavidc pdavidc added this to the WebWW v0.10.0 milestone May 22, 2018
@ghost ghost assigned pdavidc May 23, 2018
pdavidc
pdavidc suggested changes May 23, 2018
View reviewed changes
Copy link
Contributor

@pdavidc pdavidc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @zglueck. I noticed a few small things that need adjustment:

  1. functionalTest should be registered as a WebStorm test root. I've pushed changes for this.

  2. The functional test files need more descriptive names. I anticipate be lots of functional tests covering various aspects (performance correctness, etc). Each test needs to be easily identifiable. How about SurfaceShapePerformance.html/js.

  3. The functional test files need to start a folder hierarchy. Let's use mirror the src folder hierarchy, like test does.

  4. I think we should drop the graph. I'm unable to make any real meaningful inference with it. The frame time data, however, is useful and serve the need the graph intends to.

@zglueck
Copy link
Contributor Author

zglueck commented May 23, 2018

@pdavidc I've addressed 2, 3, and 4; however I need guidance with 1.

With the functionalTest directory designated as a test directory WebStorm's server function makes the content-type header equal text/html. The javascript files are then prevented from executing because:

because its MIME type ('text/html') is not executable, and strict MIME type checking is enabled.

Using an alternative server (e.g. python) allows the functional test to run, but WebStorm's built-in seems to be changing the content type header on my machine.

Is there a workaround for the content type in WebStorm?

@pdavidc
Copy link
Contributor

pdavidc commented May 23, 2018

@zglueck The content-type error is not the root of the problem. Registering the functionalTest folder as a test root affects the configuration of WebStorm's built-in web server. The paths to resources in src no longer work as expected.

@pdavidc pdavidc added the nasa label May 30, 2018
@pdavidc pdavidc removed this from the WebWW v0.10.0 milestone Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdavidc pdavidc pdavidc requested changes

@markpet49 markpet49 Awaiting requested review from markpet49

At least 1 approving review is required to merge this pull request.

Assignees

@zglueck zglueck

@pdavidc pdavidc

Labels
enhancement nasa needs review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zglueck @pdavidc